Code Reviews Can Make or Break Your Team -- The Startup -- Medium

Code Reviews Can Make or Break Your Team — The Startup — Medium

“Ugh, another code review” ~ Alice

First, she has to set up a meeting. At the meeting, everyone sits around a table. Bob points out that Alice’s variable names are 1 char too long for the naming convention. Jake says Alice needs to use a 2 space not 3 space tab stop. Heather points out that there are 3 spelling mistakes in the code comments and she shouldn’t be ending her sentences with a preposition. No one notices that Alice is passing unsanitized SQL straight to the database.

Many people fear reviews because of this

I recently wrote a surprisingly popular article on a method I’ve used to eliminate bad tech hires. [TL;DR pay candidates to do a simple, self contained project and then do a review of the project as if they were a team member]. Most of the questions about it revolved around 2 central themes : what the review process should be, and the mechanics of administering the problem.

In this article I’m going to tackle the review process by discussing what a good code review should look like. I’ll be mostly discussing the internal review process. Since you should be using the same process for the coding challenge review, the rules apply to both.

Read full article from Code Reviews Can Make or Break Your Team — The Startup — Medium