The 4 Things We Look For in a Code Review | Big Nerd Ranch
Here are a few of the things in Highgroove's Code Review tool-belt, that we look for:
-
Tests - This is a given - Ruby on Rails ships with a great test framework. Your app needs tests. The default suite will do! Many developer teams will even upgrade the testing suite, adding RSpec and Cucumber, Selenium for in-browser testing, rcov for code coverage, and FactoryGirl for fixtures and test data. Without tests, you're bound to regress ("Jim fixed a bug, but looks like he added a few more…"). Bottom line: Tests = Quality.
-
Idiomatic Ruby and Rails - Did the developers use standard plugins, or did they re-invent pagination? Did they use a search plugin or did they write their own fancy-pancy algorithm for search? Are they using helpers, or just copy-pasting code all over the place? This can tell a lot about a code-base and how easy to maintain it is and will be long-term.
Read full article from The 4 Things We Look For in a Code Review | Big Nerd Ranch
No comments:
Post a Comment