Effective Code Reviews – 9 Tips from a Converted Skeptic - Fog Creek Blog
I knew the theory. Code reviews help to:
- Catch bugs
- Ensure code is readable and maintainable
- Spread knowledge of the code base throughout the team
- Get new people up to speed with the ways of working
- Expose everyone to different approaches
Or, they’re just a giant waste of time. At least, that was my first impression of code reviews.
I was the new guy, a recent grad, developing plugins for a software company in London.
Over time I had to submit blocks of identical or similar code. They would get reviewed by the same poor, put upon guy (“he’s the best at it” my manager told me. No good deed…). Yet each review would come back picking at something different. It seemed needlessly picky and arbitrary.
Worse still, reviews would take days, if not weeks. By the time I got my code back I could hardly remember writing it. It wasn’t the guy’s fault. He’d asked for a senior dev, but had gotten me. He was sick of dealing with the issues every inexperienced developer makes, and code reviews were his way of exorcising that frustration.
Read full article from Effective Code Reviews – 9 Tips from a Converted Skeptic - Fog Creek Blog
No comments:
Post a Comment